Skip to content

chore: tests migration to assertj (KotlinStdlibCompatUtilsTest, ModelAutolinkingDependenciesJsonTest, PathUtilsTest, DependencyUtilsTest, ProjectUtilsTest)#45606

Closed
kachmashk wants to merge 2 commits into
facebook:mainfrom
kachmashk:chore/tests-migration-to-assertj
Closed

chore: tests migration to assertj (KotlinStdlibCompatUtilsTest, ModelAutolinkingDependenciesJsonTest, PathUtilsTest, DependencyUtilsTest, ProjectUtilsTest)#45606
kachmashk wants to merge 2 commits into
facebook:mainfrom
kachmashk:chore/tests-migration-to-assertj

Conversation

@kachmashk
Copy link
Copy Markdown
Contributor

@kachmashk kachmashk commented Jul 23, 2024

Summary:

#45596

Changelog:

Migrated to AssertJ within files:

  • KotlinStdlibCompatUtilsTest.kt,
  • ModelAutolinkingDependenciesJsonTest.kt,
  • PathUtilsTest.kt,
  • DependencyUtilsTest.kt,
  • ProjectUtilsTest.kt.

[INTERNAL] [CHANGED] - Migrated KotlinStdlibCompatUtilsTest, ModelAutolinkingDependenciesJsonTest, PathUtilsTest, DependencyUtilsTest, ProjectUtilsTest from junit.Assert to assertj.core.api.Assertions.

Test Plan

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Hi @kachmashk!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@react-native-bot
Copy link
Copy Markdown
Collaborator

Warnings
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against e9f806b

@kachmashk kachmashk changed the title chore: tests migration to assertj chore: tests migration to assertj (KotlinStdlibCompatUtilsTest, ModelAutolinkingDependenciesJsonTest, PathUtilsTest, DependencyUtilsTest, ProjectUtilsTest) Jul 23, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 23, 2024
@react-native-bot
Copy link
Copy Markdown
Collaborator

Warnings
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against e9f806b

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jul 23, 2024
@kachmashk
Copy link
Copy Markdown
Contributor Author

Hey @cortinico, cannot add you as a reviewer so @ you here.

Copy link
Copy Markdown
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you invert the equal assertion so that is:

assertThat(actual).isEqualTo(expected)

You have this in several tests

Copy link
Copy Markdown
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you invert the equal assertion so that is:

assertThat(actual).isEqualTo(expected)

You have this in several tests

@kachmashk
Copy link
Copy Markdown
Contributor Author

Can you invert the equal assertion so that is:

assertThat(actual).isEqualTo(expected)

You have this in several tests

Made a mistake by not checking assertEquals documentation where expected is a first argument, not second like I assumed. Reverted actual with expected within the isEqualTo.

@kachmashk kachmashk requested a review from cortinico July 24, 2024 07:18
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kachmashk
Copy link
Copy Markdown
Contributor Author

Hey @cortinico, how could I fix the Facebook Internal - Linter? I cannot see what went wrong as it's only for Meta's employees.

@cortinico
Copy link
Copy Markdown
Contributor

Hey @cortinico, how could I fix the Facebook Internal - Linter? I cannot see what went wrong as it's only for Meta's employees.

I fixed it for you. The status doesn't update automatically, but the final commit that will land will be properly formatted 👍

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 24, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico merged this pull request in 4cc46e3.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @kachmashk in 4cc46e3

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants